Add cache headers. #132
Merged
Add cache headers. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephank
force-pushed
the
featureCacheHeaders
branch
2 times, most recently
from
c3330ae
to
6e76fc4
Compare
stephank
force-pushed
the
featureCacheHeaders
branch
from
f99866e
to
84f9770
Compare
|
Changes Unknown when pulling 84f9770 on featureCacheHeaders into ** on master**. |
onli
approved these changes
Feb 1, 2017
| =============== ==================== ================ | ||
| static_ttl BROKER_STATIC_TTL 604800 (1 week) | ||
| discovery_ttl BROKER_DISCOVERY_TTL 604800 (1 week) | ||
| keys_ttl BROKER_KEYS_TTL 86400 (1 day) |
There was a problem hiding this comment.
Having the key cacheable is nice, though also problematic if combined with the key rotation of #121 (comment). If clients were to really respect the cache (which I doubt any client does, but let's assume) and the rotation happens during the time, validation should fail.
At first I wanted to suggest to you to document that problematic, but since key rotation is external to the broker, I wouldn't know where would be a good place for that. So in the end I'm just leaving this as a comment here.
|
Changes Unknown when pulling b73a6c4 on featureCacheHeaders into ** on master**. |
|
I created #134, so we won't forget! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41.
The approach here is to just set
Cache-Control: no-cache, no-storefor everything, except when overridden explicitly. The overrides are for static files, discovery and keys, each having a config var.The discovery and keys resources don't set Last-Modified and Etag. I feel like it's more trouble than it's worth?