Hyper v0.11 and openssl crate v0.9 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
August 7, 2017 21:59
- Reduce nesting - Smaller Context, handlers receive Service too - Use regular Box, instead of BoxFuture - Drops the Send requirement, no longer need Remote handles
added 3 commits
August 11, 2017 09:20
This expands the Context, making it the only parameter required for request handlers, and simplifying code a bunch.
|
Changes Unknown when pulling 21f8e31 on featureTokio into ** on master**. |
onli
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ditches Iron, uses plain Hyper 0.11, and upgrades the openssl crate to 0.9 for compatibility.
The entire request path up to calling bridges is async, and the OIDC bridge also does async HTTP requests to external systems. Mail and Redis are not async, but those are less critical I suppose.
The async changes don't really make the code any prettier. I've fought with finding a decent structure for things, but in general it's a whole lot of closures and moving things around.
Probably want to squash the commits at the end.