Improve error messages and user feedback. #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #149.
There are a bunch of changes to error handling here:
BrokerError::SessionExpired
, because I expect it to be a very common case, for which we can now give better feedback. The other classes ofBrokerError::Input
are all integration issues, and can use the generic template.BrokerError::ProviderInput
, which covers some of the previous cases forBrokerError::Provider
andBrokerError::Input
. This is specifically for errors related to the request input (thus 400), not provider communication (still 503). AllBrokerError::Input
is now related to the RP, while allBrokerError::Provider*
is related to the provider. Error messages reflect this.@onli Can you push a commit here with German translations for the new messages, if you can spare moment? :)
Example Dutch 'session expired' page:
![screen shot 2017-10-27 at 15 24 55](https://user-images.githubusercontent.com/89950/32106627-7d9cb140-bb2c-11e7-8dce-f0146dbddc59.png)
Example Dutch 'internal error' page:
![screen shot 2017-10-27 at 15 24 04](https://user-images.githubusercontent.com/89950/32106640-863db9ca-bb2c-11e7-9b41-f4ae4275d973.png)