PHP8 READ_AHEAD fix #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When $i > 0, $this->file->seek($i) returns false and foreach is never executed.
olimination
reviewed
Oct 21, 2021
| @@ -200,7 +200,9 @@ public function rewind() | |||
| { | |||
| $this->file->rewind(); | |||
| if (null !== $this->headerRowNumber) { | |||
| $this->file->seek($this->headerRowNumber + 1); | |||
| for ($i = 0; $i <= $this->headerRowNumber; $i++) { | |||
There was a problem hiding this comment.
As far as I understand we could simplify the code here based on the PHP issue here: php/php-src#6434
the following should work too:
$this->file->seek($this->headerRowNumber);
$this->file->next();What do you think @czoIg and @ddeboer ?
I have also created once a patch here: https://github.com/Comvation/csv/tree/fix-php8-csvreader-seek
|
Closing this because it seems this bug was fixed in PHP 8.0.1, so making the change here shouldn’t be necessary. Thanks for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$i > 0,$this->file->seek($i)returns false and foreach is never executed.