Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Generators #68

Open
Baachi opened this issue Dec 8, 2017 · 2 comments
Open

[RFC] Generators #68

Baachi opened this issue Dec 8, 2017 · 2 comments

Comments

@Baachi
Copy link
Contributor

Baachi commented Dec 8, 2017

If i want to import a large dataset, i use generators mostly. Because they are more memory friendly.
Maybe we could use generators to process the workflow.

But this would means, it would be hard BC break.

Here is a blog post from K-Phoen about generators and import some stuff

http://blog.kevingomez.fr/2016/01/20/use-cases-for-php-generators/

WDYT @ddeboer @sagikazarmark

@ddeboer
Copy link
Member

ddeboer commented Dec 8, 2017

I’m all for using generators: it’s one of the principles of the PortPHP library to keep memory use to a minimum.

@Baachi Where should we start implementing them?

@Baachi
Copy link
Contributor Author

Baachi commented Feb 23, 2018

Sorry for the late response.

I think we should start by the readers. Because this is the part where the most memory will be consumed.

@Baachi Baachi mentioned this issue Feb 25, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants