Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping ParkPos check doesn't match GroundNetTest.testIntersectingParking from terrasync/main check #2

Closed
Honu4 opened this issue Jul 15, 2020 · 7 comments

Comments

@Honu4
Copy link

Honu4 commented Jul 15, 2020

Check results show no errors. But pull request check finds overlapping parking positions.

Is it possible to have FG-airports check the same radius as GroundNetTest.testIntersectingParking in the pull request check?

@Honu4
Copy link
Author

Honu4 commented Jul 15, 2020

To add a little background, I think #1 has a lot to do with this but v0.20 doesn't show the circle so it's difficult to see the radius intersecting.

@wkitty42
Copy link

this is why i had so many KCLT uploads today...

@BecOzIcan
Copy link

Most Auto Tests are missing from v0.20.
Please Hold on to your submissions and spend more time on testing your work directly in Flightgear

@wkitty42
Copy link

speaking for myself: i've been testing mine since before i first wrote an issue saying that i was working on them... i've been working on KRDU for a few years and am still not happy with it but i'm getting there... i haven't listed it, yet, though...

i don't know how you got all those craft at KCLT and/or KCHS to go off across the grass but whoa... it might have had something to do with my attempts to make travis happy... that was my main goal at the time, anyway... once travis is happy with the file and the groundnet/groundweb is in place, then i can clean it up a more as needed...

@BecOzIcan
Copy link

Satisfying Travis tests is not an indication your groundnet will be functional (but opposite is true)
Only your own extensive testing in real conditions can achieve that.
Refer to : terrasync/main#414

@Portree-Kid
Copy link
Owner

Moving to Travis Test

@Portree-Kid Portree-Kid transferred this issue from Portree-Kid/flightgear-airports Jul 16, 2020
@Portree-Kid
Copy link
Owner

Groundnet Test now matches in V1.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants