-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce Abstract #137
Enforce Abstract #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! @vilim? @diegoasua?
Love this consistency. Clear and strong 👍 . Just remember to lint it before merging and good to go |
Thanks for the approval @diegoasua @vigji ! Sorry if it wasn't clear from the description |
Oh I did not see this was a draft, cool work, let me know when it's finished for a re-review |
Pull Request Test Coverage Report for Build 2101667796
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
shutdown method non abstract
making abstract classes and interfaces inherit from abc: