Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests pipeline #147

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Update tests pipeline #147

wants to merge 5 commits into from

Conversation

fedem-p
Copy link
Member

@fedem-p fedem-p commented Oct 16, 2022

Updated some github actions

One test unfortunately leaves python hanging silently.
It seems to be a problem related to the .join function that doesn't have a timeout.

here's the stack trace:

Traceback (most recent call last):
  File "c:\users\feder\miniconda3\envs\napari-env\lib\multiprocessing\util.py", line 357, in _exit_function
    p.join()
  File "c:\users\feder\miniconda3\envs\napari-env\lib\multiprocessing\process.py", line 149, in join
    res = self._popen.wait(timeout)
  File "c:\users\feder\miniconda3\envs\napari-env\lib\multiprocessing\popen_spawn_win32.py", line 108, in wait
    res = _winapi.WaitForSingleObject(int(self._handle), msecs)```

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3260034336

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1263 unchanged lines in 32 files lost coverage.
  • Overall coverage decreased (-43.06%) to 36.685%

Files with Coverage Reduction New Missed Lines %
sashimi/hardware/external_trigger/interface.py 1 75.0%
tests/test_gui.py 1 66.67%
sashimi/hardware/light_source/interface.py 3 73.68%
sashimi/hardware/scanning/init.py 3 70.42%
tests/conftest.py 3 66.67%
sashimi/hardware/cameras/interface.py 4 74.6%
sashimi/hardware/light_source/mock.py 4 59.09%
sashimi/hardware/external_trigger/stytra.py 6 31.58%
sashimi/waveforms.py 13 41.3%
sashimi/processes/logging.py 15 50.0%
Totals Coverage Status
Change from base Build 2744873404: -43.06%
Covered Lines: 1080
Relevant Lines: 2944

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants