-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates stephan #268
Updates stephan #268
Conversation
…y structure, which also supports versioned packages
…Lamnidis_2018 test package
Excellent - some last comments (I hope):
Let me know if you agree with these ideas and whether I should take over and implement some of them. |
OK, list now has its own column for "Is latest". I also noticed that the raw output so far did not print out the column headings, which is however vital, in particular with additional janno columns when listing individuals, so I now added this to the raw output (see for example golden test output for test-pipeline |
Regarding the second point, I have now changed the default behaviour. I looked at the golden test outputs, and think that |
Regarding points 3 and 4 I agree! I think you wanted to take a stab at the release changelog, and regarding point 4 yes, I will make a PR to the schema (no Poseidon version change, just a clarification, I think) |
…ed through all the consequences
OK very cool, I've reviewed the code changes and ran a few command line tests on the test-data. I'm happy. What do you say? I say, we merge and start a test-release, then get the rest of the ball going. Of course, finalist the release only after further tests and update of the server. |
I've added a fix for validate, which would fail if some packages were skipped if |
I am working on a few updates and some refactoring of #264