Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Ingress on gcp doesnt work by default. #1409

Merged
merged 2 commits into from Jan 13, 2024
Merged

Conversation

8ball030
Copy link
Contributor

High level description of the change.

When deployed to GCP I hit this issue;

k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: Failed to watch *v1.EndpointSlice: failed to list *v1.EndpointSlice: endpointslices.discovery.k8s.io is forbidden: User "system:serviceaccount:ingress:default" cannot list resource "endpointslices" in API group "discovery.k8s.io" at the cluster scope

I added the extra cluster rbacs to the ingress class and all seems to now work.

Testing

I deployed on GCP and was able to route ingress traffic to a contianer in the cluster.

8ball030 and others added 2 commits January 12, 2024 11:13
feat ensured that appropriate rbacs are set to allow the ingressclass…
@dghubble
Copy link
Member

Thanks

Closes #1350

I'd be curious to hear about your usage because I've been weighing removing the addon examples Kubernetes manifests, or maybe replacing them with Terraform modules.

@dghubble dghubble merged commit af719e4 into poseidon:main Jan 13, 2024
@8ball030
Copy link
Contributor Author

Oh that was convenient.
Wasn't aware I'd fixed an issue.
I am a pretty heavy user of this to be candid.
It is kind of my go to.

In terms of improvements, I always end up having to basically do a couple of things;

A) setup the ingress controller.
(An option in the initial tf module I.e. ingress_enabled: bool) would save me time.

B) normally I end up having to setup a wildcard dns entry into the cluster

C) I normally have to deploy certmanager

D) I almost always have to setup persistent storage. For example an efs mount to the workers such that I can use a nfs controller to manage volumes.

Thanks again for merging my pr, it's quite cool to be a contributor to this repo, I've been using it for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants