Support Rocky Linux 8 #428
Conversation
SungtanKim
requested review from
huijeong-kim,
sejun000,
git-ohkwon and
syeonshin
|
혹시 도와드릴 사항이 있을까요? 패치에 부족한 점 있다면 부담 없이 피드백 주시기를 부탁드리겠습니다. |
|
pkgdep.sh의 기존 구현에 따르면 배포판 별로 해당 스크립트 내에서 분기를 태우는 형태로 되어 있는데 이와 유사하게 가면 좋을 것 같네요. Rocky Linux의 경우 대표적인 RHEL 파생 배포판들(CentOS 등)에서도 해당 스크립트가 동일하게 적용될 수 있다면 |
해당 사항 반영하여 커밋하였습니다.
일부 라인 수정 후 CentOS Stream 8 에서 동작 확인하였습니다. RHEL 8은 제공하지 않는 패키지가 있어 우선 보류하였습니다. 요청 주시면 구현 검토해 보도록 하겠습니다. |
This commit adds pkgdep_rocky8.sh for installing dependencies in Rocky Linux, and fixes compile issues (which is mostly from using different version of gcc) We tried not to break on Ubuntu environments and we tested on our machine. Signed-off-by: Hyunseung Park <hspark0582@gluesys.com>
Signed-off-by: Hyunseung Park <hspark0582@gluesys.com>
Installing dependencies were originally done in a new separate file, pkgdep_rocky8.sh. As recommended in a review comment, we have combined the two into pkgdep.sh. We have tested new pkgdep.sh against Ubuntu 18.04, Rocky Linux 8.6, and also CentOS Stream 8. There were some changes to make the script also work on CentOS. We have thought of making it also run on RHEL itself, but since it does not provide some packages we can use on Rocky/CentOS, we need to manually build them (too) or use CentOS repositories. We will consider implementing it if you desire. Finally, some refactoring using PKGS variable. Now it looks (hopefully/arguably) less ugly while still not calling dnf every time.
Just copied spdk os check :)
Error occurred while installing go in rocky/CentOS since minimal install of them does not have wget and tar. I messed up the order during combining scripts. Sorry!
This commit adds pkgdep_rocky8.sh for installing dependencies in Rocky Linux 8, fixes compile issues (which is mostly from using different version of gcc), and some other issues.
We tried not to break on Ubuntu environments and we have tested on our machine, but we would like to hear from you if there are any issues.
Note that running
build_lib.shandbuild_ibofos.shseparately (and thus building library twice) caused compile/runtime error on Rocky systems, so we stuck to running onlybuild_ibofos.sh, or manually runningconfigureandmakeafterbuild_lib.sh.Signed-off-by: Hyunseung Park hspark0582@gluesys.com