Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

Support Rocky Linux 8 #428

Merged
merged 7 commits into from Oct 18, 2022
Merged

Support Rocky Linux 8 #428

merged 7 commits into from Oct 18, 2022

Commits on Oct 13, 2022

  1. Support Rocky Linux 8

    This commit adds pkgdep_rocky8.sh for installing dependencies in Rocky Linux,
    and fixes compile issues (which is mostly from using different version of gcc)
    We tried not to break on Ubuntu environments and we tested on our machine.
    
    Signed-off-by: Hyunseung Park <hspark0582@gluesys.com>
    hspark0582 authored and so931 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    750aa90 View commit details
    Browse the repository at this point in the history
  2. Use ifndef instead of removing a #define

    Signed-off-by: Hyunseung Park <hspark0582@gluesys.com>
    hspark0582 authored and so931 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e41c6c5 View commit details
    Browse the repository at this point in the history
  3. Combine pkgdep scripts into one file

    Installing dependencies were originally done in a new
    separate file, pkgdep_rocky8.sh. As recommended in a
    review comment, we have combined the two into pkgdep.sh.
    
    We have tested new pkgdep.sh against Ubuntu 18.04,
    Rocky Linux 8.6, and also CentOS Stream 8. There were
    some changes to make the script also work on CentOS.
    We have thought of making it also run on RHEL itself,
    but since it does not provide some packages we can use
    on Rocky/CentOS, we need to manually build them (too)
    or use CentOS repositories. We will consider
    implementing it if you desire.
    
    Finally, some refactoring using PKGS variable.
    Now it looks (hopefully/arguably) less ugly while
    still not calling dnf every time.
    hspark0582 authored and so931 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    fd91967 View commit details
    Browse the repository at this point in the history
  4. Use os-release rather than centos-release

    Just copied spdk os check :)
    hspark0582 authored and so931 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    67c4afb View commit details
    Browse the repository at this point in the history
  5. Install go after installing necessary packages

    Error occurred while installing go in rocky/CentOS since minimal install of them does not have wget and tar.
    I messed up the order during combining scripts. Sorry!
    hspark0582 authored and so931 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    13e44dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f4c4f86 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Configuration menu
    Copy the full SHA
    fe10851 View commit details
    Browse the repository at this point in the history