Add IsInstalled API to installer interface #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IsInstalled(cmd, bin string) bool` will help tools using this library to show a prompt to users asking if they would like to have completion enabled.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 89.93% 89.93%
=======================================
Files 14 14
Lines 864 864
=======================================
Hits 777 777
Misses 77 77
Partials 10 10Continue to review full report at Codecov.
|
|
Thanks, looks good. |
I tested gocomplete with bash and fish, with zsh it doesn't work even with master version (or I am missing something.. I am not a zsh user) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsInstalled(cmd, bin string) boolwill help tools using this libraryto show a prompt to users asking if they would like to have completion
enabled.
Fixes #89