-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct branch name in the badges #102
base: master
Are you sure you want to change the base?
Conversation
Hi Mark. I see the issue you are suggesting on. |
Thanks @posener, I'll make the change tomorrow. |
馃憢 Hello agian @posener! I referenced this fork by commit SHA in our repo. You can now see all of the features this fork has added in the readme file of the @deliveryhero pipelines repo. This version uses Thanks again for the feedback 馃檹 |
Hi Mark, I think this PR is currently mixing multiple things. The branch name issue, adding badges, allowing modify commit messages. Usually one would create a different independent PR for each of these. Scoping back to the branch name issue. I think that the failure you get is because the call uses a the env variables from Github action environment. You should protect the call with |
Thanks again for the feedback @posener! You're right, this isn't a very clean PR. I just implemented all of the badge features we needed in one go. It would have been better in hind-sight if I had made separate branches and PRs for the commit message override, the github actions badge, and the branch name fix. It looks like the repo has changed significantly since my fork and there are merge conflicts now. We'll just keep using my fork for now and if you ever get around to incorporating these features into the action we'll switch back. Feel free to close this PR. Best, |
馃憢 @posener. We're using this action to generate our readme over here and I noticed that all of our badges were broken (our
master
branch is calledmain
).I added a feature that renders the HEAD branch name in the template by default or a
branch
override flag. I also added a GitHub workflow bage, and a flag to override the default commit message. Let me know what you think.Finally, the checks appear to be failing, but I don't understand why. All of the tests are passing locally.