Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running multiple versions of PoshBot side-by-side #122

Merged
merged 3 commits into from Oct 6, 2018

Conversation

Tadas
Copy link
Contributor

@Tadas Tadas commented Oct 4, 2018

This makes PoshBot more "portable" and makes it possible to run multiple versions side-by-side

Description

Instead of relying on Import-Module PoshBot to load a module found via $env:PSModulePath we explicitly specify which module manifest to load. That way you can have PoshBot installed in your system while also working on a newer version.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devblackops devblackops self-requested a review October 6, 2018 03:34
@devblackops devblackops self-assigned this Oct 6, 2018
@devblackops
Copy link
Member

Thanks @Tadas! I ran through some tests and this looks good to me. Even exposed an unrelated bug which I'll be fixing 🐛

@devblackops devblackops merged commit afdf2d4 into poshbotio:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants