Send typing indicator to Teams conversation #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to using the command parser to determine if a message is a command
This reverts commit 485ac52.
update my fork
update files for new branch
…ithub.com/AndrewPla/PoshBot into Send-typing-indicator-Issue-poshbotio#127
|
Awesome @AndrewPla. I'll check this out. |
|
@AndrewPla This looks good to me! It's a shame Teams doesn't support this in normal channels. I can't merge this while it's in draft mode. Can you change the status please? From the looks of this user voice item, support in channels may be a ways off. |
|
Draft status was removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the typing indicator per the documentation at https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-connector-activities?view=azure-bot-service-4.0#typing
It is worth noting that I haven't been able to get it to work in a channel, just a DM. I didn't see anything in the documentation indicating that it's only supported in DM conversations, but I am unable to see typing indicators from other Users typing in channels. Feedback is appreciated on this part. The code will attempt to send the typing indicator whether or not the message was received from a DM.
Feedback is appreciated
Related Issue
Addresses Issue #127 - Feature Request: Send a typing indicator for Teams
Motivation and Context
This will allow you to receive a typing indicator in Teams. This is great for longer running commands because it let's the user know the message was received and the bot is working.
How Has This Been Tested?
I have been using this for a week or so in our environment. It sends a typing indicator to DM conversations but I'm not seeing a response when the bot replies to a channel.
Screenshots (if appropriate):
Types of changes
Checklist: