Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt* methods to vertical and horizontal padding #154

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

rich-iannone
Copy link
Member

Given there is padding in the cells of different locations, we could set these globally through modification of parameters in tab_options(). This is cumbersome because cleanly scaling an entire table up and down should involve a single scaling factor, and the user would need to scale current length values for the appropriate padding options and set those in one go.

Having the opt* methods opt_vertical_padding() and opt_horizontal_padding() makes this much easier. The only parameter needed here is scale.

Fixes: #153

@github-actions github-actions bot temporarily deployed to pr-154 February 1, 2024 18:37 Destroyed
@github-actions github-actions bot temporarily deployed to pr-154 February 1, 2024 18:58 Destroyed
@github-actions github-actions bot temporarily deployed to pr-154 February 1, 2024 19:01 Destroyed
@github-actions github-actions bot temporarily deployed to pr-154 February 1, 2024 19:13 Destroyed
@rich-iannone rich-iannone marked this pull request as ready for review February 1, 2024 19:45
@rich-iannone rich-iannone merged commit 9435b4e into main Feb 1, 2024
7 checks passed
@rich-iannone rich-iannone deleted the opt-methods-for-padding branch February 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add opt* methods for changing global padding settings (vertical and horizontal)
1 participant