Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should make and make install accomplish? #73

Closed
tdstein opened this issue Mar 4, 2024 · 0 comments
Closed

What should make and make install accomplish? #73

tdstein opened this issue Mar 4, 2024 · 0 comments
Assignees
Milestone

Comments

@tdstein
Copy link
Collaborator

tdstein commented Mar 4, 2024

...continuation of #60

The make install target currently executes pip install -e . (editable install). This makes sense for development purposes, but it differs from the normal expectations of a make install. Typically, make install copies the executable to /usr/local, thus making it available across the system for the user.

In our case, we are creating a Python package. Therefore, it doesn't make sense to copy anything to /usr/local but the analogous situation would be installing the library across the Python environment. Both editable and static installs accomplish this goal but have slightly different use cases.

To maintain some level of conventional behavior for make install, I suggest modifying make install to install the static wheel output from make build. Then, add make dev to execute pip install -e ..

@tdstein tdstein self-assigned this Mar 6, 2024
@tdstein tdstein closed this as completed Mar 6, 2024
@nealrichardson nealrichardson added this to the 0.1.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants