ci: fix main workflow

[nealrichardson]

#60 updated the pull request workflow but also needed to update the main workflow, which was not triggered on the PR. This PR fixes that and modifies that workflow to run when the workflow file is touched, which should trigger it on this PR.

That said, I'm not sure why we need a separate workflow to run on main from the one we run on PRs.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
282	246	87%	80%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 96cf05a by action🐍

[tdstein]

Did you mean to commit this?

[nealrichardson]

🤦 Yes I did, but I meant to edit it to be main.yaml instead, which would explain why it didn't run here

[nealrichardson]

Suggested change

	pull_request:
	paths:
	- '.github/workflows/cpp.yml'
	pull_request:
	paths:
	- '.github/workflows/main.yaml'

[tdstein]

Oh neat! So, to confirm my understanding... this runs main.yaml anytime the file is changed on a pull request?

[nealrichardson]

Correct--you can see that it just ran now that I fixed it. So it still wouldn't have caught the change in #60 since I didn't touch this file. But if we ever edit this file in the future, the PR will run it, we won't have to wait for it to land on main.

Since this is basically testing the Makefile, we could also have it run when the Makefile is modified?

[tdstein]

That makes sense. I like the idea of workflows being task-focused instead of branch-focused. e.g., makefile.yaml instead of main.yaml or something...

[tdstein]

That said, I'm not sure why we need a separate workflow to run on main from the one we run on PRs.

Out of habit, I set up main to verify that the default development workflow (e.g., make && make install) is functional. This is just the habit I've created for myself. Open to other ideas, though!

The only current difference is that the pull request performs the coverage report.

[nealrichardson]

That said, I'm not sure why we need a separate workflow to run on main from the one we run on PRs.

Out of habit, I set up main to verify that the default development workflow (e.g., make && make install) is functional. This is just the habit I've created for myself. Open to other ideas, though!

The only current difference is that the pull request performs the coverage report.

Got it.

I would think we'd want coverage running on main so that we could track it over time. That said, I don't plan on spending much time thinking about our coverage numbers.