Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deployment selection button to open Entrypoint files #1848

Open
dotNomad opened this issue Jun 18, 2024 · 1 comment
Open

Add Deployment selection button to open Entrypoint files #1848

dotNomad opened this issue Jun 18, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@dotNomad
Copy link
Collaborator

dotNomad commented Jun 18, 2024

On hold waiting for the API changes in #1847

This PR will add the publish button to the open entrypoint files.

To determine if the button should be added we can call the new /api/inspect?entrypoint=path API. If any results are in the response we know its a valid entrypoint.

When the button is clicked:

  • Call the new /api/deployments?entrypoint=path endpoint
  • Guide the user to create a new Deployment / Configuration with that file as the entrypoint if one doesn’t exist
  • Select the Deployment / Configuration in the sidebar with that entrypoint if length === 1
  • Prompt the user to select from the multiple Deployments with the given entrypoint

Part of the #1846 epic.

@dotNomad
Copy link
Collaborator Author

I see this button as an alternative to opening the sidebar and selecting a Deployment, not as a button to initiate a deployment. That will still be the job of the sidebar.

@dotNomad dotNomad added this to the Beta (v1.0.beta3) milestone Jun 25, 2024
@dotNomad dotNomad self-assigned this Jun 25, 2024
@dotNomad dotNomad removed the hold label Jul 3, 2024
@dotNomad dotNomad changed the title Add Deploy button to open Entrypoint files Add Deployment selection button to open Entrypoint files Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant