Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show project dir when selecting entrypoints #1955

Open
wants to merge 1 commit into
base: sagerb-fix-files-view-for-subdirectories
Choose a base branch
from

Conversation

sagerb
Copy link
Collaborator

@sagerb sagerb commented Jul 12, 2024

Intent

Type of Change

Show the projectDirs in the multit-step selectors for entrypoints

Part of #1845

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

2024-07-12 at 10 18 AM

Automated Tests

Directions for Reviewers

The three multi-steppers were updated in the same way, adding the projectDir to their detail attribute.

You can invoke them by:

  • New Config from config view
  • New Deployment when there are multiple entrypoints
  • Select Config, when there are multiple entrypoints with the same content type as the current deployment.

You should verify that the projectDir is shown in those multiSteps.

Checklist

@sagerb sagerb changed the base branch from main to sagerb-fix-files-view-for-subdirectories July 12, 2024 17:57
@sagerb sagerb self-assigned this Jul 12, 2024
Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. So simple 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants