Add progress indicator for loading of deployments view #1957
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation of children
sagerb
requested review from
dotNomad,
kgartland-rstudio,
mmarchetti and
tdstein
as code owners
dotNomad
approved these changes
Jul 15, 2024
Comment on lines
+95
to
+97
| async () => { | ||
| return getAllPromise; | ||
| }, |
There was a problem hiding this comment.
Similar question to the last PR wondering if we need to wrap this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Resolves #1952
Only change required to make deployments view work in multi-subdirectory world was to add a progress indicator when calling the API.
Type of Change
Approach
Simply updated per existing patterns
Automated Tests
Directions for Reviewers
Verify loading and refresh of deployment view (expanded) when VSCode has opened a large folder and a small one.
Checklist