Add progress indicator for homeview APIs #1959
Open
+121
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagerb
requested review from
dotNomad,
kgartland-rstudio,
mmarchetti and
tdstein
as code owners
dotNomad
approved these changes
Jul 15, 2024
Comment on lines
+322
to
+324
| async () => { | ||
| return apiRequest; | ||
| }, |
There was a problem hiding this comment.
Okay its 2 PR's late, but I did try unwrapping these and since it isn't a function it fails to typing 😞
Comment on lines
+1249
to
+1257
| window.withProgress( | ||
| { | ||
| title: "ReFreshing Files", | ||
| location: { viewId: Views.HomeView }, | ||
| }, | ||
| async () => { | ||
| return apiRequest; | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I wonder if each of our views should have a helper to show progress like the below:
private showProgress(promise: Promise<unknown>, title: string) {
return window.withProgress(
{
title: title,
location: { viewId: Views.HomeView },
},
async () => promise,
);
}
Could make it a bit less verbose each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Resolves #1958
Adds a HomeView progress indicator while API calls are outstanding
Type of Change
Approach
Wrapped API calls with VSCode's
withProgresscall, showing on the HomeView.Automated Tests
Directions for Reviewers
Verify you see a progress indicator within HomeView when it is initializing, after switching to publisher view. This will be very visible if you open a very large folder in VSCode as the base dir.
Checklist