Disable homeview's Easy Deploy View until ready #1961
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagerb
requested review from
dotNomad,
kgartland-rstudio,
mmarchetti and
tdstein
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Resolves #1960
Type of Change
Approach
Added a new message which is returned after the extension believes the initialization queries have been completed.
Then I added a variable within the home store that indicates if initialization is complete or not.
Message handlers update the value of the variable within the home store, and then the EvenEasierDeploy vue reacts to the value of that ref.
End Result:
Kapture.2024-07-12.at.13.51.39.mp4
Automated Tests
Directions for Reviewers
Open a very large folder with VSCode, activate the publisher and verify the proper views are visible after initialization.
Do the same with a small folder.
Checklist