Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiny express seems to export more than it should #972

Closed
cpsievert opened this issue Jan 4, 2024 · 1 comment · Fixed by #978
Closed

Shiny express seems to export more than it should #972

cpsievert opened this issue Jan 4, 2024 · 1 comment · Fixed by #978
Labels

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Jan 4, 2024

Looks like Inputs, Outputs, Session, annonations, and app are being included by mistake?

>>> import shiny.express as sx
>>> sx.[TAB]
sx.Inputs(            sx.annotations          sx.display_decorator   sx.suspend_display(
sx.Outputs(         sx.app                        sx.is_express_app(     sx.ui
sx.Session(         sx.display_body()     sx.output_args(            sx.wrap_express_app(

I haven't validated this, but my gut feeling is that these issues derive from the fact that express isn’t included in shiny/__init__.py...

@wch
Copy link
Collaborator

wch commented Jan 6, 2024

It's not because express isn't included in shiny/__init__.py -- it's because shiny/express/__init__.py imports those types.

from ..session import Inputs, Outputs, Session

But I believe that this can be fixed by doing from ..session import Inputs as _Inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants