Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add underscores to hide some imports #978

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add underscores to hide some imports #978

merged 2 commits into from
Jan 8, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented Jan 6, 2024

Closes #972.

The behavior with this change:

>>> import shiny.express as sx
>>> sx.[TAB]
sx.annotations        sx.display_body()     sx.is_express_app(    sx.suspend_display(   sx.wrap_express_app(  
sx.app                sx.display_decorator  sx.output_args(       sx.ui

@wch wch requested a review from cpsievert January 6, 2024 04:15
@cpsievert
Copy link
Collaborator

cpsievert commented Jan 8, 2024 •
edited
Loading

I still see shiny.express.annotations and shiny.express.app, which don't seem like things we want to export. I don't know of a nice way to get rid of the former, but can we just remove app?

@wch
Copy link
Collaborator Author

wch commented Jan 8, 2024

I agree about app, so I made the change and pushed.

cpsievert
cpsievert approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wch wch merged commit 592cf34 into main Jan 8, 2024
26 checks passed
@wch wch deleted the express-ui-ns branch January 8, 2024 18:08
schloerke added a commit that referenced this pull request Jan 8, 2024
@schloerke
Merge branch 'main' into drop_fn_session_param
1ca6917 
* main: (24 commits)
  Use dynamic version of py-shiny for deploy tests (#970)
  Add underscores to hide some imports (#978)
  Add rsconnect json files(shinyapps.io tests) and folium tests (#928)
  Express' `value_box()` no longer includes named positional args (#966)
  Include `tooltip()` and `popover()` in express (#949)
  Remove extra call to run_express()
  Call `tagify()` early to intercept `AttributeErrors` (#941)
  Don't pass sidebar twice to navbar_page
  Update changelog
  Update changelog
  Switch from `requests` to `urllib` (#940)
  Bump version to 0.6.1.1
  Fix docstring for page_opts
  Fix API doc sections for Express
  Smarter, lazier, and more complete page default/api for express (#893)
  Change `express.layout` to `express.ui` (#904)
  Remove `@output` from examples (#790)
  feat: Allow for `App` `server=` to take `input` only (#920)
  Add fixes for type stub generation (#828)
  Move quarto express docs to bottom
  ...
schloerke added a commit that referenced this pull request Jan 9, 2024
@schloerke
Merge branch 'main' into shiny-create-bugs
597d836 
* main:
  Use dynamic version of py-shiny for deploy tests (#970)
  Add underscores to hide some imports (#978)
  Add rsconnect json files(shinyapps.io tests) and folium tests (#928)
  Express' `value_box()` no longer includes named positional args (#966)
  Include `tooltip()` and `popover()` in express (#949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shiny express seems to export more than it should
2 participants
@wch @cpsievert