Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove express.ui.output_* functions, add shiny.express.render #1018

Merged
merged 26 commits into from
Jan 17, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented Jan 16, 2024

This is another take on #1004, but it:

  • Does not bring in all output arguments to the renderer functions
  • Re-exports shiny.render as shiny.express.render. In the future, shiny.express.render.* functions will gain some more output arguments, but there are a number of open questions about that which we need to resolve.

@wch wch changed the base branch from main to render-code January 16, 2024 23:44
@wch wch marked this pull request as draft January 16, 2024 23:45
@wch wch marked this pull request as ready for review January 17, 2024 17:14
@wch wch changed the base branch from render-code to main January 17, 2024 17:35
@wch wch added this to the v0.7.0 milestone Jan 17, 2024
@wch wch merged commit e1f61bf into main Jan 17, 2024
22 of 25 checks passed
@wch wch deleted the render-output-2 branch January 17, 2024 17:47
This was referenced Jan 17, 2024
cpsievert added a commit to posit-dev/py-shinywidgets that referenced this pull request Jan 17, 2024
schloerke added a commit that referenced this pull request Jan 19, 2024
* main: (26 commits)
  api!: Merge RendererBase class into Renderer (#1032)
  chore(render.display): Improve error message (#1020)
  `express.ui.page_opts(title = ...)` now always generates a header (#1016)
  api!: `Renderer.auto_output_ui()` drops `id` arg. Make `RendererBase.output_id` a non-namespaced value. (#1030)
  fix(page_sidebar): Add semicolon to end style declaration (#1027)
  chore: Remove experimental from app (#1028)
  chore: Expose `render.renderer.RendererBaseT` and do not require `| None` when defining Renderer types (#1026)
  bug: Restore legacy renderers while packages transition (#1023)
  Update deploy test apps to use render.code
  Update changelog
  Provide useful message in Express when `input` was not imported (#994)
  Calculate coordinate mapping after drawing figure (#999)
  Remove `express.ui.output_*` functions, add `shiny.express.render` (#1018)
  fix: Do not allow for renderer's to be given to reactive effects (#1017)
  Truncate the requirements.txt file before deploys (#998)
  Update changelog
  Fixes for flake8 (#1012)
  Pin starlette version below 0.35 (#1009)
  Remove shiny express warning
  Cause RecallContextManagers to run when used without `with` (#992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants