Don't run effects created in a MockSession
#1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
approved these changes
Jan 23, 2024
This was referenced Jan 23, 2024
Closed
schloerke
added a commit
that referenced
this pull request
Feb 13, 2024
* main: (33 commits) test: Test apps locally before deploying via pytest fixtures. (#1055) docs: Add ExtendedTask to API index (#1088) Fix `render.download` in Shiny Express, take 2 (#1085) Bump version to 0.7.0.9000 Create two different api doc folders, one for Core and one for Express (#1053) chore: Pin black to version 23 (#1077) chore: Remove github link to shinylive (#1069) Bump version to 0.7.0 Raise when `express.[input,output,session]` are used outside of Express app (#1067) Update dashboard template (#1056) chore: Remove many broken quartodoc links (#1061) Update {bslib} (#1062) Update docstrings for `expressify`, `hold`, and `render.express` (#1066) Add `fill` to `__all__` in `ui` and `express.ui` (#1064) Update shiny.js (#1059) docs(examples): Use refactored shinylive syntax (#1048) Update `shiny.js` (#1052) Add `express.ui.panel_title` (#1039) Don't run `effect`s created in a `MockSession` (#1049) Delete shiny/api-examples/Calc directory (#1044) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1034.
This PR makes it so that when a
@reactive.effectis used in the UI-rendering phase of a Shiny Express app, it's a no-op; it doesn't schedule the function to be run later, during a reactive flush.Some thoughts about how this might be improved/generalized in the future:
MockSessionandSessioncould to both be subclasses of another class, likeBaseSession. OrMockSessioncould just be a subclass ofSession.effect.__init__(), it currently does an explicit check ifsessionis aMockSessionobject, but that is a bit crude. Instead,SessionandMockSessioncould have a method, likeis_reactive(), whicheffect.__init__()could query to find out whether it should schedule execution on a reactive flush.MockSession.__init__()method could take an argument,is_reactive, to tell it whether to do reactivity or not. This could be useful if theMockSessionclass is used for other purposes, like testing.