Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename app.py examples to app-core.py #1076

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

gshotwell
Copy link
Contributor

We have a standardized way of naming template files with app-core.py and app-express.py. This changes our api examples to follow that pattern. This has a few beenfits:

  • Clear which file is which
  • Easier to keep express and core examples in sync if they're in the same place
  • Express and core apps can share submodules (e.g. plotting helpers)

@gshotwell gshotwell assigned gshotwell and gadenbuie and unassigned gshotwell Jan 26, 2024
@gadenbuie
Copy link
Collaborator

Thanks! Looks like we're getting errors that might be due to a recent update from black? They're definitely unrelated to the changes in this PR, so I'm going to merge.

@gadenbuie gadenbuie merged commit f9c9ddd into add-examples-express-split Jan 26, 2024
9 of 26 checks passed
@gadenbuie gadenbuie deleted the rename-app-files branch January 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants