Allow serving static assets in Shiny Express apps #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
force-pushed
the
express-static-assets
branch
from
f9c06d8
to
91a72cc
Compare
schloerke
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #984. This PR does the following for Shiny Express apps:
wwwsubdirectory, mounting it at/express.app_opts(), which allows setting options that get passed to theApp()constructor. This includesstatic_assetsanddebug.And it adds this change for Shiny in general:
App()constructor, thestatic_assetsare now sorted by their mount point, from longest string to shortest before actually mounting them. This because previously, if an app had mounts"/"and"/foo", specified in that order, it would never actually serve anything in the"/foo"mount because it would search the"/"mount first.