Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement/improve nav() API by implementing in Python instead of React/JSX #136

Merged
merged 15 commits into from
Apr 28, 2022
Merged

Implement/improve nav() API by implementing in Python instead of React/JSX #136

merged 15 commits into from
Apr 28, 2022

Commits on Apr 26, 2022

  1. Switch from React/JSX to Python for constructing nav() markup

    @cpsievert
    cpsievert committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    76f87a8 View commit details
    Browse the repository at this point in the history

  2. code review

    @cpsievert
    cpsievert committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    df4fac9 View commit details
    Browse the repository at this point in the history

  3. No more need for bs3compat.js (or downloading JSX implementation)

    @cpsievert
    cpsievert committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f10383a View commit details
    Browse the repository at this point in the history

  4. Add unit tests and fix some bugs

    @cpsievert
    cpsievert committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a094fb3 View commit details
    Browse the repository at this point in the history

  5. Use a Protocol for typing navigation items inside consumers 

    This way others can create their own custom nav item classes
    @cpsievert
    cpsievert committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    0bec791 View commit details
    Browse the repository at this point in the history

  6. No need to import pytest

    @cpsievert
    cpsievert committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a29640e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. add comment; fix type

    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a2fbca9 View commit details
    Browse the repository at this point in the history

  2. Use a more general context object to pass info between parent/child r… 

    …elationships
    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    2bbc607 View commit details
    Browse the repository at this point in the history

  3. Rename navs_*() to navset_*(); add a dedicated class for containers w… 

    …ith a tagify() method (so we can add other useful methods in the future); add a tagify() method to Nav/NavMenu as well that raises informative error
    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    c630f16 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into server-side-navs

    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    47f9e07 View commit details
    Browse the repository at this point in the history

  5. Remove nav_content() from the API

    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    2f8fb5a View commit details
    Browse the repository at this point in the history

  6. Rename nav_item() to nav_control()

    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    c9c152f View commit details
    Browse the repository at this point in the history

  7. Rename directory

    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    b19cb74 View commit details
    Browse the repository at this point in the history

  8. Bump version to signify breaking changes

    @cpsievert
    cpsievert committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    6d5357a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Leverage inheritance to stor additional layout parameters

    @cpsievert
    cpsievert committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    99d18b5 View commit details
    Browse the repository at this point in the history