Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data frame): Restore input.<ID>_selected_rows(). Rename input.<ID>_data_view_indices to input.<ID>_data_view_rows #1377

Merged
merged 6 commits into from
May 14, 2024
Merged

feat(data frame): Restore input.<ID>_selected_rows(). Rename input.<ID>_data_view_indices to input.<ID>_data_view_rows #1377

merged 6 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Restore input.<ID>_selected_rows(). Add tests

    @schloerke
    schloerke committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d558dab View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @schloerke
    schloerke committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8abf8eb View commit details
    Browse the repository at this point in the history

  3. Only subset the selected data if the index row exists! 

    Fixes #1351
    @schloerke
    schloerke committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1b3d2a8 View commit details
    Browse the repository at this point in the history

  4. Make sure the index being subsetted is less than the row length, not … 

    …contained in the index
    @schloerke
    schloerke committed May 14, 2024
    Configuration menu
    Copy the full SHA
    bbb70c1 View commit details
    Browse the repository at this point in the history

  5. Rename input.<ID>_data_view_indices to input.<ID>_data_view_rows

    @schloerke
    schloerke committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b370063 View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG.md

    @schloerke
    schloerke committed May 14, 2024
    Configuration menu
    Copy the full SHA
    eb84220 View commit details
    Browse the repository at this point in the history