-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data frame): Support basic cell styling #1475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: tests(controls): Change API from controls to controller (#1481) fix(docs): Update path to reflect correct one (#1478) docs(testing): Add quarto page for testing (#1461) fix(test): Remove unused testrail reporting from nightly builds (#1476) chore(pyright): Remove version restriction and fix appropriate pyright errors (#1473)
… replace with full combination on the fly
…h can be styled by user)
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Jul 2, 2024
* main: fix(tests): dynamically determine the path to the shiny app (posit-dev#1485) tests(deploys): use a stable version of html tools instead of main branch (posit-dev#1483) feat(data frame): Support basic cell styling (posit-dev#1475) fix: support static files on pyodide / py.cafe under a prefix (posit-dev#1486) feat: Dynamic theming (posit-dev#1358) Add return type for `_task()` (posit-dev#1484) tests(controls): Change API from controls to controller (posit-dev#1481) fix(docs): Update path to reflect correct one (posit-dev#1478) docs(testing): Add quarto page for testing (posit-dev#1461) fix(test): Remove unused testrail reporting from nightly builds (posit-dev#1476)
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~~POC for styling cells via
great_tables
package. ~~ POC proven.great_tables
support pushed to later release.Using this approach as
great_tables
has generic styling support, whereas thestyler
component ofpandas
is only for pandas andgreat_tables
is already integrated intopolars
. Hopefully for the next release, both py-shiny and great-tables will be leveragingnarwhals
("Lightweight and extensible compatibility layer between Polars, pandas, cuDF, Modin, and more"). This way, both py-shiny gets styling support for any data frame package! (Related: #1439)Example excerpt:
Update: June 27th:
While the
great_tables
integration was a success, it brought up problems for howrender.data_frame
was to interact with theGT
object. We will approach this subject in a 1.1 release.For now, the
styles=
parameter has been added torender.DataTable
andrender.DataGrid
. This value can either be a list of style info objects or function (given data as a param) that returns a list of style objects. This style function will be called after any cells have been updated as styling for the whole table may change due to a single cell update.Ex: