Send busy/idle when an Effect is executing and output binding progress when an Output is recalculating #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
output-progress
branch
3 times, most recently
from
89c5c4a
to
ac86826
Compare
wch
reviewed
Jun 8, 2022
cpsievert
force-pushed
the
output-progress
branch
2 times, most recently
from
9920f14
to
5ebea25
Compare
wch
reviewed
Jun 15, 2022
wch
reviewed
Jun 15, 2022
wch
reviewed
Jun 15, 2022
tests/test_poll.py
Outdated
Comment on lines
37
to
39
| async def _send_message(self, message: Dict[str, object]) -> None: | ||
| pass | ||
|
|
There was a problem hiding this comment.
Yea, without it defined, unit tests will fail (so it's either define it here or check that the method exists before calling it in Effect_)
It'll probably make more sense to revisit this "lack of a MockSession" problem in a future PR that I'm working on, so I wouldn't worry about it too much right now
cpsievert
force-pushed
the
output-progress
branch
from
5ebea25
to
0048759
Compare
cpsievert
force-pushed
the
output-progress
branch
from
0048759
to
48c6594
Compare
wch
reviewed
Jun 15, 2022
wch
approved these changes
Jun 15, 2022
Co-authored-by: Winston Chang <winston@stdout.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185
Closes #16