Fixed defects related to lodash 4.x upgrade

README.md

@@ -2,7 +2,7 @@
 
 ![](logo/postaljs.jpg "Special Thanks to Derick Bailey for the postal logo!")
 
-## Version 1.0.9 ([MIT](http://www.opensource.org/licenses/mit-license))
+## Version 1.0.10 ([MIT](http://www.opensource.org/licenses/mit-license))
 
 > See the [changelog](https://github.com/postaljs/postal.js/blob/master/changelog.md) for information on if the current version of postal has breaking changes compared to any older version(s) you might be using. Version 0.11+ removed the dependency on ConduitJS and significantly improved publishing performance. Version 1.0+ added an optional embedded-and-customized-lodash build.
 

changelog.md

@@ -1,3 +1,7 @@
+## v1.0.10
+* Fixed issue where removed lodash alias was still in use
+* Fixed issue `this` context issue in postal.subscribe
+
 ## v1.0.9
 * Merged #148 - Updated to lodash 4.x
 * Merged #128 - Remove unused bower.json version prop

component.json

@@ -2,7 +2,7 @@
     "name": "postal.js",
     "repo": "postaljs/postal.js",
     "description": "Client-side messaging library",
-    "version": "1.0.9",
+    "version": "1.0.10",
     "keywords": [
         "pub/sub",
         "pub",

lib/postal.js

@@ -1,7 +1,7 @@
 /**
  * postal - Pub/Sub library providing wildcard subscriptions, complex message handling, etc.  Works server and client-side.
  * Author: Jim Cowart (http://ifandelse.com)
- * Version: v1.0.9
+ * Version: v1.0.10
  * Url: http://github.com/postaljs/postal.js
  * License(s): MIT
  */
@@ -106,7 +106,7 @@ var ConsecutiveDistinctPredicate = function() {
 var DistinctPredicate = function DistinctPredicateFactory() {
 	var previous = [];
 	return function DistinctPredicate( data ) {
-		var isDistinct = !_.any( previous, function( p ) {
+		var isDistinct = !_.some( previous, function( p ) {
 			return _.isEqual( data, p );
 		} );
 		if ( isDistinct ) {
@@ -601,14 +601,15 @@ _.extend( postal, {
 		// First, add the SubscriptionDefinition to the channel list
 		subs.push( subDef );
 		// Next, add the SubscriptionDefinition to any relevant existing cache(s)
-		_.each( _.keys( this.cache ), function( cacheKey ) {
+		var cache = this.cache;
+		_.each( _.keys( cache ), function( cacheKey ) {
 			if ( cacheKey.substr( 0, channelLen ) === subDef.channel ) {
 				getCacher(
 					cacheKey.split( _config.cacheKeyDelimiter )[1],
-					this.cache,
+					cache,
 					cacheKey )( subDef );
 			}
-		}, this );
+		} );
 
 		if ( _config.enableSystemMessages ) {
 			this.publish( sysCreatedMessage( subDef ) );

lib/postal.lodash.js

@@ -1,7 +1,7 @@
 /**
  * postal - Pub/Sub library providing wildcard subscriptions, complex message handling, etc.  Works server and client-side.
  * Author: Jim Cowart (http://ifandelse.com)
- * Version: v1.0.9
+ * Version: v1.0.10
  * Url: http://github.com/postaljs/postal.js
  * License(s): MIT
  */
@@ -129,7 +129,7 @@ var ConsecutiveDistinctPredicate = function() {
 var DistinctPredicate = function DistinctPredicateFactory() {
 	var previous = [];
 	return function DistinctPredicate( data ) {
-		var isDistinct = !_.any( previous, function( p ) {
+		var isDistinct = !_.some( previous, function( p ) {
 			return _.isEqual( data, p );
 		} );
 		if ( isDistinct ) {
@@ -624,14 +624,15 @@ _.extend( postal, {
 		// First, add the SubscriptionDefinition to the channel list
 		subs.push( subDef );
 		// Next, add the SubscriptionDefinition to any relevant existing cache(s)
-		_.each( _.keys( this.cache ), function( cacheKey ) {
+		var cache = this.cache;
+		_.each( _.keys( cache ), function( cacheKey ) {
 			if ( cacheKey.substr( 0, channelLen ) === subDef.channel ) {
 				getCacher(
 					cacheKey.split( _config.cacheKeyDelimiter )[1],
-					this.cache,
+					cache,
 					cacheKey )( subDef );
 			}
-		}, this );
+		} );
 
 		if ( _config.enableSystemMessages ) {
 			this.publish( sysCreatedMessage( subDef ) );

package.json

@@ -1,7 +1,7 @@
 {
   "name": "postal",
   "description": "Pub/Sub library providing wildcard subscriptions, complex message handling, etc.  Works server and client-side.",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "homepage": "http://github.com/postaljs/postal.js",
   "repository": {
     "type": "git",

src/Api.js

@@ -198,14 +198,15 @@ _.extend( postal, {
 		// First, add the SubscriptionDefinition to the channel list
 		subs.push( subDef );
 		// Next, add the SubscriptionDefinition to any relevant existing cache(s)
-		_.each( _.keys( this.cache ), function( cacheKey ) {
+		var cache = this.cache;
+		_.each( _.keys( cache ), function( cacheKey ) {
 			if ( cacheKey.substr( 0, channelLen ) === subDef.channel ) {
 				getCacher(
 					cacheKey.split( _config.cacheKeyDelimiter )[1],
-					this.cache,
+					cache,
 					cacheKey )( subDef );
 			}
-		}, this );
+		} );
 		/* istanbul ignore else */
 		if ( _config.enableSystemMessages ) {
 			this.publish( sysCreatedMessage( subDef ) );

src/SubscriptionDefinition.js

@@ -32,7 +32,7 @@ var ConsecutiveDistinctPredicate = function() {
 var DistinctPredicate = function DistinctPredicateFactory() {
 	var previous = [];
 	return function DistinctPredicate( data ) {
-		var isDistinct = !_.any( previous, function( p ) {
+		var isDistinct = !_.some( previous, function( p ) {
 			return _.isEqual( data, p );
 		} );
 		if ( isDistinct ) {