Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Content-Id header on attachments through send message API #2841

Closed
memcorrupt opened this issue Mar 5, 2024 Discussed in #2817 · 1 comment
Closed

Set Content-Id header on attachments through send message API #2841

memcorrupt opened this issue Mar 5, 2024 Discussed in #2817 · 1 comment

Comments

@memcorrupt
Copy link

memcorrupt commented Mar 5, 2024

Discussed in https://github.com/orgs/postalserver/discussions/2817

Originally posted by memcorrupt February 24, 2024
Good to see that postalserver seems to have resumed development. 馃檶

Currently, there is no support for setting the Content-Id header on attachments sent through /api/v1/send/message. I'm not quite well versed enough with the project & programming in Ruby to pull request it at this time, but from my brief look into the source code, I believe it can be implemented pretty easily.

  1. Add cid parameter and handling to attachments in send_api_controller.rb, so that it gets passed to OutgoingMessagePrototype.new
  2. Set content_id key within mail.attachments[name].

If there is any documentation that could ease the setup of a development environment for Postal, I could attempt to make the changes and PR them upstream.

@willpower232
Copy link
Collaborator

I direct your attention to https://github.com/postalserver/postal/blob/main/CONTRIBUTING.md for the information you seek and kindly ask not to duplicate discussions into issues 馃檹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants