Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrent placeholder #143

Closed
drgullin opened this issue Dec 11, 2013 · 6 comments
Closed

Incorrent placeholder #143

drgullin opened this issue Dec 11, 2013 · 6 comments
Labels

Comments

@drgullin
Copy link

According to the docs from CSS-tricks http://css-tricks.com/almanac/selectors/p/placeholder/:

  • ::-moz-placeholder is used by ff >= 19
  • :-moz-placeholder by ff <= 18.

Autoprefixer doesn't add :-moz-placeholder for the older versions of Firefox.

Now, if I have ff >= 5 in the settings, I get

::-webkit-input-placeholder {
  color: #eee;
}

::-moz-placeholder {
  color: #eee;
}

:-ms-input-placeholder {
  color: #eee;
}

::placeholder {
  color: #eee;
}

While the true result is

::-webkit-input-placeholder {
  color: #eee;
}

:-moz-placeholder {
  color: #eee;
}

::-moz-placeholder {
  color: #eee;
}

:-ms-input-placeholder {
  color: #eee;
}

::placeholder {
  color: #eee;
}

Also, it seems there's no need for ::placeholder { color: #eee; }, since there's likely no browser that supports placeholder styling without prefixes. So the final expected result is:

::-webkit-input-placeholder {
  color: #eee;
}

:-moz-placeholder {
  color: #eee;
}

::-moz-placeholder {
  color: #eee;
}

:-ms-input-placeholder {
  color: #eee;
}
@ai
Copy link
Member

ai commented Dec 11, 2013

::placeholder is needed for the future browser ;)

@ai
Copy link
Member

ai commented Dec 11, 2013

I try to add this :-moz-placeholder on this week, but maybe it will be fixed only after 1.0 release (because ff < 18 is very old and Source Map support and bugfixes from 1.0 is important).

@drgullin
Copy link
Author

We may also need :placeholder (one dotted, see the -ms) in the future http://wiki.csswg.org/ideas/placeholder-styling

Since the overall code for a placeholders isn't smart (there also should be some .placeholder class for a fallback), I vote for removing the ::placeholder until at least one browser supports it (anyway, it will also support the prefixed rule, so no probs).

::placeholder is simply bulk nowadays.

@ai
Copy link
Member

ai commented Dec 11, 2013

But it is little bit confuced, that we remove original property.

Of cource, with ::placholder is a problem, that there is no unprefixed version. But, I think, ::placholder is more likely to be relalised.

@drgullin
Copy link
Author

Let's keep a ::placeholder then, due to overall existance of the unprefixed styles.

@ai
Copy link
Member

ai commented Dec 25, 2013

Fixed 51cd314

@ai ai closed this as completed Dec 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants