fix: preserve calc when extra parentheses are used #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludofischer
reviewed
May 4, 2023
|
Good job! I think we're very close to being able to simplify the external parentheses completely. Regarding the second TODO, do you think there's a reason to preserve the space around the division operator? |
|
@ludofischer Thank you! After implementing your suggested changes, it seems we're very close to completely fixing the bug. In regards to the second TODO, I don't think there is any reason to preserve the space around the division operator. Especially because that space isn't preserved in other tests within |
ludofischer
approved these changes
May 5, 2023
alexander-akait
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
This fix allows
calcto be printed whencalc((...))is encountered. The bug occurred because the AST was'type: 'ParenthesizedExpression'which didn't satisfy theshouldPrintCalccheck instringifier.js. The test I added piggy backs on the work started in #180. All the original tests pass with this addition, but I am new to the codebase so I very well could be missing some things.cssnano/cssnano#1490 (comment)
TODOs:
calc((var(--foo) / var(--bar))should becomecalc(var(--foo) / var(--bar)calc((var(--foo) / var(--bar))should preserve the space if that is intended/expected behavior.