Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to apply default styles #2

Closed
niksy opened this issue May 24, 2015 · 5 comments
Closed

Option to apply default styles #2

niksy opened this issue May 24, 2015 · 5 comments
Labels

Comments

@niksy
Copy link

niksy commented May 24, 2015

If you want to apply :hover styles to :focus styles, I think it’s reasonable to think that you want to remove default outline on focus with outline:0;. Therefore, maybe it would be nice to have some initial styling applied?

@ai
Copy link
Member

ai commented May 24, 2015

It is difficult to find best place to insert this outline:0;. Some components are independent, so be can’t use *:focus {}. Some times user will concat CSS files after PostCSS, so we can’t put *:focus {} in every file.

Anyway it is just a one line of code.

But maybe we can put this outline cleaner to plugin example? Do you want to send PR?

@ai ai added the question label May 24, 2015
@niksy
Copy link
Author

niksy commented May 25, 2015

I was think of putting outline cleaning only to transformed :hover styles, so I suppose it won’t affect other selectors which only use :focus styles, only those with :hover. But I see your reasoning of focusing to one thing and one thing only.

As for outline cleaner, you mean creating another plugin, or just a option for this plugin?

@ai
Copy link
Member

ai commented May 25, 2015

Hm. Good way. But I think it will make this plugin to complicated. Just one *:focus {} is better for many users. Maybe we should create a separated plugin for users who want it.

@ai
Copy link
Member

ai commented Aug 23, 2015

Yeap, I think *:focus { outline: 0 } is a better way

@ai
Copy link
Member

ai commented Aug 23, 2015

I just add it to example c1a0e80

@ai ai closed this as completed Aug 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants