Rewrite composes rules inside @imported stylesheets
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, sorry, it's all github picking the bad branch. |
vitalif
force-pushed
the
rewrite-composes-11.x
branch
from
6bd4920
to
166731d
Compare
|
We do not formally support css-modules, so this is out of scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. There is a problem with postcss-import that it doesn't rewrite relative paths in
composes: x from '../file'when inlining@imported files, which breaks this kind of composition in css modules. I think the best place to fix it is postcss-import itself; also I couldn't find a way to fix it by configuration of any other loaders or plugins.I've prepared two versions of this fix - for master and for 11.1.0. Could you please merge it?