-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend and fix data url imports #534
Merged
romainmenke
merged 3 commits into
master
from
extend-and-fix-data-url-imports--adventurous-uakari-79de749a0a
Jul 22, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,7 @@ function AtImport(options) { | |
state, | ||
[], | ||
[], | ||
"", | ||
postcss | ||
) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,6 @@ | ||
p { color: green; } | ||
@import url(foo.css);p { color: green; }p { color: blue; }@media (min-width: 320px){@layer foo{ | ||
p { color: green; } } }@media (min-width: 320px){@layer foo{ | ||
|
||
p { color: blue; } | ||
|
||
@media (min-width: 320px) { | ||
|
||
@layer foo { | ||
p { color: green; } } } | ||
|
||
@media (min-width: 320px) { | ||
|
||
@layer foo { | ||
|
||
p { color: blue; } } } | ||
|
||
/* Mixed imports: */ | ||
|
||
foo{} | ||
|
||
p { | ||
p { color: blue; } } }/* Mixed imports: */p { | ||
color: blue; | ||
} | ||
|
||
p { color: pink; } | ||
}p { color: pink; }/* url encoded: */bar { color: green }bar { color: pink } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a data url eventually unfurls into a regular import with a relative path it should stop and must not inline the relative import.
Each import is resolved relatively to it's parent and when the parent is a data url there isn't any domain or base url to resolve a url against.
I think usage of data urls was already very niche and that it is extremely unlikely that anyone depends on the old behavior.