Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore loader object in postcss config context #355

Merged
merged 2 commits into from Apr 16, 2018
Merged

fix: restore loader object in postcss config context #355

merged 2 commits into from Apr 16, 2018

Conversation

kisenka
Copy link
Contributor

@kisenka kisenka commented Apr 6, 2018

ℹ️ Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Type


ℹ️ What types of changes does your code introduce?

Put an x in the boxes that apply

  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Feature
  • Refactor

SemVer


ℹ️ What changes to the current semver range does your PR introduce?

Put an x in the boxes that apply

  • Bug (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Issues


ℹ️ What issue (if any) are closed by your PR?

Replace #1 with the error number that applies

  • Fixes #354

Checklist


ℹ️ You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is a reminder of what we are going to look for before merging your code.

Put an x in the boxes that apply.

  • [] Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@coveralls
Copy link

coveralls commented Apr 6, 2018

Coverage Status

Coverage increased (+1.3%) to 89.308% when pulling 53a0005 on kisenka:loader-in-ctx into ce2adca on postcss:master.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexander-akait
Copy link
Member

@kisenka will be great if you add test

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kisenka
Copy link
Contributor Author

kisenka commented Apr 6, 2018

@michael-ciniawsky could you please take a look, thanks!

@kisenka
Copy link
Contributor Author

kisenka commented Apr 13, 2018

@evilebottnawi @michael-ciniawsky could someone please merge and publish a new version?

@alexander-akait
Copy link
Member

/cc @ai looks @michael-ciniawsky unavaliable, i can't merge without second eye and can't have right on publish

@ai
Copy link
Contributor

ai commented Apr 13, 2018

Looks good. But I prefer to wait @michael-ciniawsky. I will release only critical issue.

@kisenka you can use GitHub version of postcss-loader before this PR will released.

@alexander-akait
Copy link
Member

@ai looks like regression, in 1 version we have this feature https://github.com/postcss/postcss-loader/blob/v1.0.0/index.js#L72. For someone, this can be critical

@ai
Copy link
Contributor

ai commented Apr 13, 2018

OK. I will release it today

@ai ai merged commit 2ff1735 into webpack-contrib:master Apr 16, 2018
@ai
Copy link
Contributor

ai commented Apr 16, 2018

Released 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants