Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove outdated integration tests #163

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

alexander-akait
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Oct 24, 2018

Coverage Status

Coverage remained the same at 95.394% when pulling b506a5f on chore-remove-outdated-integration-tests into 1f96ac2 on master.

@@ -3,20 +3,17 @@ sudo: false
language: node_js
matrix:
include:
- node_js: '10'
env: INTEGRATION=false
- node_js: '11'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to remove 10, as it is a LTS version of node? Maybe add latest to the matrix for 11?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leipert fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

@alexander-akait alexander-akait force-pushed the chore-remove-outdated-integration-tests branch from 21fabeb to b506a5f Compare October 24, 2018 14:51
@jonathantneal jonathantneal merged commit 23d702b into master Oct 24, 2018
@jonathantneal jonathantneal deleted the chore-remove-outdated-integration-tests branch October 24, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants