fix: isPseudoElement() supports :first-letter and :first-line

[ybiquitous]

Browsers supports also :first-letter and :first-line pseudo-elements introduced in CSS2.

• https://developer.mozilla.org/en-US/docs/Web/CSS/::first-letter
• https://developer.mozilla.org/en-US/docs/Web/CSS/::first-line

[alexander-akait]

@ybiquitous hm, so we parse them as pseudo elements? I think it is bug (for before and fater), because we should parse them as is (i.e. no own decisions), if it was written as pseudo elements we should return pseudo element and versa vice, otherwise linters and another tools, can't understand how developer really write them

[ybiquitous]

@alexander-akait Thanks for the quick feedback.

Do you mean it's unnecessary to check :before or :after in the first place like this?

export function isPseudoElement (node) {
    return isPseudo(node) && node.value && node.value.startsWith("::");
}

I don't know the background that isPseudoElement was introduced, so I don't have a strong opinion about these type-guard functions.
Surely, postcss-selector-parser has a Pseudo node type, but doesn't have a PseudoElement or PseudoClass node type.

[alexander-akait]

Surely, postcss-selector-parser has a Pseudo node type, but doesn't have a PseudoElement or PseudoClass node type.

Oh... that is bad, I messed it

I see what you want, ideally we should rename function to isLegacyPseudoElement, but it will be breaking change, so let's left the same name

[alexander-akait]

Ping me tomorrow, I will do release (I relocated to another city and small busy today)

[ybiquitous]

@alexander-akait Don't mind. Thank you for the review. ☺️
I'm not hurrying. Feel free to merge and release when you can afford it.

[alexander-akait]

Thanks

[alexander-akait]

@ybiquitous Released https://github.com/postcss/postcss-selector-parser/releases/tag/v6.0.10, sorry for delay

[ybiquitous]

@alexander-akait Thank you! 🎉