Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've create an postcss org #65

Closed
MoOx opened this issue Jul 29, 2014 · 36 comments
Closed

I've create an postcss org #65

MoOx opened this issue Jul 29, 2014 · 36 comments
Labels

Comments

@MoOx
Copy link
Contributor

MoOx commented Jul 29, 2014

Following this segmentio/myth#100
I've created this https://github.com/postcss
Note: if myth team is not interested, I'll create a fork :/

If you want to move postcss over there that can be great, but to be honest, it's not an issue if you want to keep it here, I will understand :)

Have a nice day & thanks for your work.

@ai
Copy link
Member

ai commented Jul 29, 2014

I want to move postcss to new org, but how we can do it best? Does GitHub create redirects for old users?

@MoOx
Copy link
Contributor Author

MoOx commented Jul 29, 2014

Yes it should now !

@MoOx
Copy link
Contributor Author

MoOx commented Jul 29, 2014

If it don't (but I'm pretty sure it does), you can recreate a repo with the same name under your profile then offer a README with a manual redirection :)

@ai
Copy link
Member

ai commented Jul 29, 2014

OK. I will move project tomorrow or after tomorrow (today I will annonce PostCSS 2.1 and Autoprefixer 2.2 releases).

@MoOx
Copy link
Contributor Author

MoOx commented Jul 29, 2014

Awesome !
For my concern, I'll try to handle all the plugins I created under the org asap, based on rework-* tests :)

@ai
Copy link
Member

ai commented Jul 29, 2014

BTW, @iAdramelk in middle of creating postcss-import plugin. Maybe we should also put it to org?

@MoOx
Copy link
Contributor Author

MoOx commented Jul 29, 2014

sure. done. It would be nice if he reuse the test I've done here https://github.com/reworkcss/rework-import :)

@ai
Copy link
Member

ai commented Aug 4, 2014

@MoOx Maybe we should move Autoprefixer to postcss repo too?

@MoOx
Copy link
Contributor Author

MoOx commented Aug 5, 2014

As you wish. But I'm not sure it's the goal of the postcss org.
I think you can keep it for you.
In the same spirit, I'll create a myth like processor, based on postcss & I've not planned to put it under postcss org: https://github.com/putaindecode/cssnext

@ai
Copy link
Member

ai commented Aug 5, 2014

But what is a difference between small plugin and tool? What will be a goal for plugins in postcss org?

@ai ai added enhancement and removed enhancement labels Aug 5, 2014
@jonathanong
Copy link

i think anything postcss related belongs in the org :) it's nice to see everything in one place and know it's "official"

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

@ai usage will be really different. Plugins can be used with postcss api, tools can hide this api & might not be used as a plugin.
As a end-user, for a project I can choose to use postcss + plugins directly to have a custom css processor. You might not be able to do that with tools.
That's why I want to separate plugins in the README :)
And like @jonathanong, "official" things are a good things and give credits to the repo.

@ai
Copy link
Member

ai commented Aug 6, 2014

@MoOx OK. I think to move Autoprefixer to PostCSS org (but, of cource, it is not a rule of other tools):

  1. It will promote PostCSS.
  2. Autoprefixer is supported by same authores.
  3. Autoprefixer always use latest PostCSS like reference implementation.

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

As you wish :)

@jonathanong
Copy link

it would be nice to refactor autoprefixer into a postcss-autoprefixer plugin with postcss.use(autoprefixer()) then let autoprefixer be a standalone version (with postcss, etc. included). doing .use(autoprefixer().postcss) is weird to me.

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

+1 for this :)

@ai
Copy link
Member

ai commented Aug 6, 2014

autopreifxer will be too small, because all logic will be in postcss-autoprefixer.

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

That's not an issue to me. Checkout plugins like postcss-calc or rework-color-function.
It's even better. :)

@ai
Copy link
Member

ai commented Aug 6, 2014

But what be the point of postcss-autoprefixer?

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

Same goal as postcss-*
Direct use for custom css processing.
For example my next project will just use chained postcss plugins. That will be great to be able to just get the minimal dependency (no cli stuff for example).

@ai
Copy link
Member

ai commented Aug 6, 2014

You can use autoprefixer now:

postcss()
  .use( autoprefixer(browsers).postcss )

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

I know I can do that. But when I get autoprefixer dep, I also get some dependencies or some code that are probably not needed for my usage.
That being said. You can still offer autoprefixer().postcss since you will use postcss-autoprefixer as a dep.

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

Also smaller modules encourage better code decoupling, easier tests & more.

@ai
Copy link
Member

ai commented Aug 6, 2014

Hm. You are right, I forget about binary. But maybe autoprefixer-cli will be better? A lot of non-PostCSS npm modules depends on autoprefixer, but didn’t use binary.

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

I think if nobody ask you that before, it's probably because most of people don't look deps & don't care.
But some people like me & jonathan care about that (just a bit)
Also, like myth, it's nice to have binary in autoprefixer so npm i -g autoprefixer directly give the bin available.
But offering a smaller module that just give what is necessary for people that already have other dep loaded seems a good thing.
Should not be a big deal.

@ai
Copy link
Member

ai commented Aug 6, 2014

Maybe for better compatibility we should use autoprefixer and autoprefixer-core (without binary)?

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

autoprefixer-core will be the postcss plugin ? If so, you can just extract the postcss plugin from autoprefixer & call it postcss-autoprefixer, then use it in autoprefixer.

@ai
Copy link
Member

ai commented Aug 6, 2014

autoprefixer-core will be like current autoprefixer, but without binary and its dependencies.

Or autoprefixer-core will be like postcss-autoprefixer, but also with process() method :).

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

so you can do this dep tree

|-- autoprefixer
|------ autoprefixer-core
|---------- // ...
|---------- postcss
|---------- postcss-autoprefixer

Or

|-- autoprefixer-cli //
|------ autoprefixer (v3, since api change (no more cli))
|---------- // ...
|---------- postcss
|---------- postcss-autoprefixer

For my concern, I will just go (for now) extracting postcss plugin as postcss-autoprefixer, then keep autoprefixer with bin (that not the huge part).

|-- autoprefixer
|------ // ...
|------ postcss
|------ postcss-autoprefixer

@ai
Copy link
Member

ai commented Aug 6, 2014

I still didn’t see any benefits of postcss-autoprefixer. autoprefixer-core will be enough.

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

Will autoprefixer-core have postcss as dep ? if so the postcss plugin can be extracted :) So, when I use postcss directly I can get the minimal postcss-autoprefixer dep.
But do as you want, it's not a big deal for me. I'm thorough :D

@ai
Copy link
Member

ai commented Aug 6, 2014

OK, I will create autoprefixer-core after few weeks (when I finish my vacation with my brother): postcss/autoprefixer#294

@MoOx
Copy link
Contributor Author

MoOx commented Aug 6, 2014

Nice. Enjoy your vacations then ;)

@jonathanong
Copy link

you can also put the standalone in ai/autoprefixer. i think the standalone being in autoprefixer-rails is a little weird. haha

@ai
Copy link
Member

ai commented Aug 7, 2014

I agree, that it is more logically to put standalone build in autoprefixer, but its isn’t necessary in autoprefixer, but autoprefixer-rails must to have standalone build.

So, I can have two files in autoprefixer and autoprefixer-rails. But I didn’t like to put build files in repository (it is easy to forget udpdate it on next commit).

@ai
Copy link
Member

ai commented Aug 19, 2014

Done. autoprefixer is in postcss org now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants