Add dump_genesis command in cli #511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junha1
reviewed
Aug 29, 2023
| @@ -76,6 +76,8 @@ pub enum SignCommands { | |||
|
|
|||
| #[derive(Debug, Subcommand)] | |||
| pub enum Commands { | |||
| /// Dumps genesis block files to the path | |||
There was a problem hiding this comment.
Dummy? Dump? Please match the word
| .await | ||
| .unwrap(); | ||
|
|
||
| let keys = serde_spb::to_string(&keys)?; |
There was a problem hiding this comment.
Please remove unnecessary newlines here
Jeongseup
force-pushed
the
cli/add-dump-genesis
branch
from
bb8f474
to
80e0300
Compare
|
Could you please review again? I modified as what you said. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that it is useful to make dummy genesis files which will be used in dev or easy start