Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dnsPolicy to the Helm chart #45

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Apr 6, 2022

Running the csr-approver with dnsPolicy: Default should works fine and removes the dependency to CoreDNS. It's a nice catch on initial cluster bootstrapping.

I also bump the helm chart version in prepare for a next release. Please note, that the v prefix of a helm chart version is not officially supported, since it requires to be a SemVer value.

image

@ghouscht
Copy link
Contributor

ghouscht commented Apr 7, 2022

Thank you for the PR, looks good to me. I'm just waiting for the CI to pass and will merge the PR then.

Thanks for the hint regarding the v prefix on the Helm chart version, I was not aware of that! I will create a follow up issue regarding that.

ps. Can you please tell me what editor plugin you use for Helm charts? 😃

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2102170866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.699%

Totals Coverage Status
Change from base Build 2076517303: 0.0%
Covered Lines: 158
Relevant Lines: 206

💛 - Coveralls

@ghouscht ghouscht merged commit f7ec7b8 into postfinance:main Apr 7, 2022
@jkroepke jkroepke deleted the dns-policy branch April 7, 2022 09:09
@jkroepke
Copy link
Contributor Author

jkroepke commented Apr 7, 2022

Hi @ghouscht

I'm using IDEA IntelliJ even for operational task. The builtin Kubernetes Plugin natively support Helm Charts and if the go Templates Plugin in installed, it also supports field validation inside helm templates.

image

https://www.jetbrains.com/help/idea/kubernetes.html#helm

No 3rd party plugins is used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants