Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #2

Merged
merged 7 commits into from
Jul 17, 2020
Merged

Feature #2

merged 7 commits into from
Jul 17, 2020

Conversation

marcsauter
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 172300552

  • 82 of 91 (90.11%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 82.841%
Changes Missing Coverage Covered Lines Changed/Added Lines %
etcd/watch.go 5 6 83.33%
etcd/etcdv3.go 26 28 92.86%
hash/hash.go 38 44 86.36%
Totals Coverage Status
Change from base Build 140672253: 0.8%
Covered Lines: 869
Relevant Lines: 1049
💛 - Coveralls

marcsauter and others added 4 commits July 16, 2020 16:20
@marcsauter
🐛
87b387d
@marcsauter
🐛
cf8ac98
@zbindenren
Update health.go
2653ca7 
Fix typo
@zbindenren
Update store.go
f7987b5 
Use errors.New instead of fmt.Errorf
@zbindenren zbindenren merged commit ea62136 into master Jul 17, 2020
@ghouscht ghouscht deleted the feature branch April 7, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbindenren zbindenren zbindenren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcsauter @coveralls @zbindenren