Change Login changePassword, fixes #456 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The db_udpate function already sets backticks around the table name, which results and error name if the string passed as argument for the table name already contains backticks. Signed-off-by: Sven Seeberg <mail@sven-seeberg.de>
DavidGoodwin
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the function
changePasswordis called, it passes the table name todb_update()which already was treated by thetable_by_key()function. However,db_update()also calls thetable_by_key()function for the table name argument. This results in double backticks and causes PHP errors for users that want to change their password.Signed-off-by: Sven Seeberg mail@sven-seeberg.de