Replace Deprecated Mail::Sender by Email::Sender #61
Conversation
specific recipient addresses
Add searchpath for local vacation.conf
Sending Mail now works at least without encryption
|
Thank you. Can you include a comment near where $novacation_pattern is specified which illustrates what it could look like? |
mailbody is already utf8, so no need to recode
VIRTUAL_VACATION/vacation.pl
Outdated
| # Replacing deprecated Mail::Sender by Email::Sender | ||
| # Add configuration parameter $novacation_pattern in order to exlude specific alias-recipients from | ||
| # sending vacation mails, even if one or multiple of the recipients the alias points to has vacation | ||
| # currently active. |
There was a problem hiding this comment.
You have a mix of tabs and spaces here. Please use only spaces.
VIRTUAL_VACATION/vacation.pl
Outdated
| # libemail-valid-perl | ||
| # libtry-tiny-perl |
There was a problem hiding this comment.
another tab that should be a space ;-)
VIRTUAL_VACATION/vacation.pl
Outdated
| # default = '' | ||
| # preventing vacation notifications for recipient info@example.org would look like this: | ||
| # our $novacation_pattern = 'info\@example\.org'; | ||
| our $novacation_pattern = ''; |
There was a problem hiding this comment.
Good idea!
Nitpicking: could you please use a slightly more readable variable name, maybe $no_vacation_pattern?
| 'Content-Type' => "text/plain; charset=utf-8", | ||
| 'X-Loop' => 'Postfix Admin Virtual Vacation', | ||
| ], | ||
| body => $body, |
There was a problem hiding this comment.
This section contains a wild mix of tabs and spaces. Please change it to spaces only.
Besides that, the new code looks good (disclaimer: I only read it, but didn't test it)
VIRTUAL_VACATION/vacation.pl
Outdated
| $logger->debug("Vacation response sent to $to from $from subject $subject sent\n"); | ||
| } | ||
| } | ||
| } |
VIRTUAL_VACATION/vacation.pl
Outdated
| @@ -695,6 +722,12 @@ sub check_and_clean_from_address { | |||
| exit(0); | |||
| } | |||
| $logger->debug("Email headers have to: '$to' and From: '$from'"); | |||
|
|
|||
| if ($to =~ /^.*($novacation_pattern).*/i) { | |||
There was a problem hiding this comment.
With the empty default value for $novacation_pattern, this will match everything, preventing vacation mails from ever being sent.
VIRTUAL_VACATION/vacation.pl
Outdated
| header => [ | ||
| To => $to, | ||
| From => $from, | ||
| Subject => $subject, |
There was a problem hiding this comment.
Why have you removed encode_mimewords($subject, 'Charset', 'UTF-8')?
This way, UTF-8 characters in vacation subjects are not encoded as quoted printable and will be rendered incorrectly.
There was a problem hiding this comment.
Because i didn't read the RFCs and tests with non ASCII-chars in the Subject worked with my client. I'll revert that change.
|
I tested this locally; test.sh didn't explode. I'll move to using it on a real server and see how that fares. Thank you! |
Replaces the deprecated Mail::Sender with Email::Sender without the need of changing master.cf.
Works with TLS on Debian Stretch
Adds a regexp novacation_pattern to define adresses where vacation E-mails never should be sent